Chore: Optimized saving of "navbar_type" in session and cookies (index.php)#4670
Open
IgorA100 wants to merge 1 commit intoZoneMinder:masterfrom
Open
Chore: Optimized saving of "navbar_type" in session and cookies (index.php)#4670IgorA100 wants to merge 1 commit intoZoneMinder:masterfrom
IgorA100 wants to merge 1 commit intoZoneMinder:masterfrom
Conversation
IgorA100
commented
Mar 1, 2026
| ) { | ||
| $_SESSION['navbar_type'] = $navbar_type; | ||
| zm_setcookie('zmNavbar_type', $navbar_type); | ||
| if (!defined('ZM_FORCE_NAVBAR_TYPE')) { |
Contributor
Author
There was a problem hiding this comment.
If we don't check for the presence of ZM_FORCE_NAVBAR_TYPE, the constant's value will always be stored in cookies and the session. But this shouldn't be done, because if a constant is defined, it will be used unconditionally (regardless of the session or cookies). This follows from the code above. if (defined('ZM_FORCE_NAVBAR_TYPE')) {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.