Skip to content

Fix broken HTML markup if !$report->FilterId() on Report page#4793

Closed
IgorA100 wants to merge 1 commit intoZoneMinder:masterfrom
IgorA100:patch-119744
Closed

Fix broken HTML markup if !$report->FilterId() on Report page#4793
IgorA100 wants to merge 1 commit intoZoneMinder:masterfrom
IgorA100:patch-119744

Conversation

@IgorA100
Copy link
Copy Markdown
Contributor

@IgorA100 IgorA100 commented May 4, 2026

No description provided.

@IgorA100
Copy link
Copy Markdown
Contributor Author

IgorA100 commented May 4, 2026

The function deleteRequest($id) in \ajax\reports.php has a !$report->canEdit() check, but I couldn't find any access rights settings for Reports.
Is Reports/Report page working correctly?

@connortechnology
Copy link
Copy Markdown
Member

connortechnology commented May 4, 2026

Probably not. It was a pretty quick rough in.

@IgorA100
Copy link
Copy Markdown
Contributor Author

IgorA100 commented May 4, 2026

That's what I thought...
Ok.
Some of the code checks permissions for "Events," and others for "Reports."
For now, we'll check for "Events" when deleting Reports. It's probably not entirely correct, but it's better than what we have now.

@IgorA100
Copy link
Copy Markdown
Contributor Author

IgorA100 commented May 4, 2026

Will be implemented here: #4792

@IgorA100 IgorA100 closed this May 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@IgorA100 @connortechnology