Skip to content

Add thumbfast integration #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Add thumbfast integration #24

wants to merge 3 commits into from

Conversation

po5
Copy link
Contributor

@po5 po5 commented Oct 29, 2022

Closes #22.

This implementation coexists with the thumbnail script currently included in this repo.
If thumbfast is present, the osc won't try to call TheAMM's thumbnailer.

Regarding your comment of your system not having socat, the latest version of thumbfast no longer requires it.
Hope this is satisfactory.

@po5
Copy link
Contributor Author

po5 commented Oct 29, 2022

Preview

thumbfast-tethys.webm

@po5
Copy link
Contributor Author

po5 commented Nov 18, 2022

What are your thoughts on this @Zren?

@WiLuX-Source
Copy link

Thank you for making this tool this works better than the current solution and I really hope it gets merged @po5. I currently manually implemented it to my client thanks!!!

@phrogg
Copy link

phrogg commented Mar 10, 2025

I get this error: osc_tethys.lua:5484: attempt to call field 'shared_script_property_set' (a nil value) apparently from this line utils.shared_script_property_set("osc-visibility", mode). Does anyone know why this occurs?

@N-R-K
Copy link
Contributor

N-R-K commented Mar 10, 2025

It's because this branch is lacking 43d87b1. Rebasing probably fixes it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Request: Thumbfast support
4 participants