Skip to content

Add an option to expand the widget in Desktop view and Panels #317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 4 commits into from

Conversation

BelkaDev
Copy link

@BelkaDev BelkaDev commented Jun 25, 2022

Note for Latte-dock users: The concerned panel must be set to normal window (sys settings) to allow accepting the focus/input

@Zren
Copy link
Owner

Zren commented Jun 25, 2022

A configuration key isn't persisted between restarts unless there's an entry in contents/config/main.xml.
https://develop.kde.org/docs/extend/plasma/widget/configuration/

Also, the logic is weird, so I'm guessing you didn't test this with plasmoidviewer. It'll default to not showing the full calendar on the desktop which is the current default behaviour.

fillPanel=true fillPanel=false
isDesktop=true Full Compact
isDesktop=false Full Compact

What we want:

fillPanel=true fillPanel=false
isDesktop=true Full Full
isDesktop=false Full Compact

- Change setting name and description (Can be applied to desktop view)
- Add experimental flag to description (Can be clunky depending on the panel/widget height & size)
@BelkaDev BelkaDev changed the title Add an option to fill the widget in panels Add an option to expand the widget in Desktop view and Panels Jul 1, 2022
@BelkaDev
Copy link
Author

BelkaDev commented Jul 1, 2022

I think some people might keep the widget on their desktop, so I changed the initial intent which was meant for panels only

@BelkaDev
Copy link
Author

BelkaDev commented Jul 4, 2022

Closing this PR as branches got mixed up
Also fixed the logic and it's now here

@BelkaDev BelkaDev closed this Jul 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants