fix(ego-lint): suppress fix text for multi-version extensions#8
Merged
fix(ego-lint): suppress fix text for multi-version extensions#8
Conversation
Add fix-min-version field to pattern rules that gates the fix suggestion based on the extension's minimum declared shell-version. R-VER48-04/04b still warn about the deprecated vertical property, but omit the "use orientation" fix when the extension targets GNOME <=46 where orientation is unavailable. Closes #7 Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #7 — R-VER48-04/04b incorrectly suggest replacing
vertical: truewithorientation: Clutter.Orientation.VERTICALfor extensions targeting GNOME 46, whereorientationis unavailable.fix-min-versionfield toapply-patterns.pythat suppresses thefix:text when the extension's minimum shell-version is below the thresholdfix-min-version: 47and inline backward-compat note in messagesmultiversion-vertical@testfixture and assertions (5 new tests, 500 total passing)Behavior
["48"]only["46", "47", "48"]["47", "48"]Test plan
bash tests/run-tests.sh— 500 passed, 0 failedapply-patterns.py --validatepasses with newfix-min-versionfields🤖 Generated with Claude Code