first rscvn commit #48
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
przemekmroz
requested changes
Aug 5, 2021
Collaborator
przemekmroz
left a comment
przemekmroz
left a comment
There was a problem hiding this comment.
A few minor things:
- inhomogenious --> inhomogeneous
- These spots rotate --> The star rotates
- However, the spot rotation period can differ slightly from the orbital period, which causes the lightcurve shape to change over timescales of years. -> What exactly do you mean? I thought that the amplitude and shape of the light curve change because the spots appear, evolve, and then disappear?
dmitryduev
requested changes
Aug 6, 2021
Collaborator
dmitryduev
left a comment
dmitryduev
left a comment
There was a problem hiding this comment.
Thank you @janvanroestel for the work! Please change the PR name to something descriptive and provide a description.
dmitryduev
reviewed
Aug 6, 2021
|  | ||
|
|
||
| ### References and further reading: | ||
| - VSX: https://www.aavso.org/vsx/index.php?view=about.vartypes |
Collaborator
|
@janvanroestel any updates on this? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.