Fixes issues which would arise on non-SP worlds #2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Based on info provided by XFactHD on the forge discord, needed fixes for removing the checks for the MC instance to ensure there are no issues when in multiplayer context.
Contributor
Author
|
Also should mention, this was a quick fix and needs more thorough testing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on info provided by XFactHD on the forge discord, this implements needed fixes after removing the previous checks for the MC instance in the packets to ensure there are no issues when in a multiplayer context.
All this does is check the dist to static initialize an optional that holds the MC instance. If for whatever reason the
ClientUtilsclass is initialized in the server, the methods within will use the newly addedOptionalto poll the MC instance, and use that optional to dictate whether inner logic of the functions should run, or if it should prematurely terminate.It also now marks the packets as handled in the packet class themselves rather than needing to pass it into the methods of
ClientUtils