xscreensaver 6.13, with changes broken down - #27
Open
hseg wants to merge 25 commits into
Open
Conversation
Although, this should just be done by pulling the rm out of the conditional
Error: --with-gles --with-glx breaks GLSL Warn: --without-setuid-hacks breaks hacks/sonar (jwz: for no good reason)
Pick up patches from build system's PAM_DIR, instead of package chroot's PAM_DIR (which will generally be empty) Of course, advisedness of such build system dependence is left as an exercise to the reader
jwz dislikes debian fragmenting the package
Ran out of time trying to figure this one out, pushed all Wayland-touching code into this commit
Looks like a typo inverted the tv.tv_usec == 0 test?
At least, I *think* this is what this rewrite is trying to accomplish?
Probably this is one of the > Some hacks were calling glXSwapBuffers before the first call to > glXMakeCurrent; allow it. cases mentioned in the upstream changelog, but couldn't quite figure it out. Removes the credit for the 2003 rewrite from Mike Oliphant for no clear reason.
iOS lacks support for some OpenGL APIs, skip them
- Misnamed manpages - Forgetting to write hypens as \- in manpages and a couple more
Author
|
After opening this, I see you've already committed the 6.13 lumped edit, am still leaving this PR here in case it's useful for folks. |
Owner
|
It would be an interesting project idea to go through the xscreensaver history and retroactively break down releases into logical change sets. I'd follow and possibly mirror that work if someone else is willing to do it. On the other hand, anyone can open a github repo, so I'm not sure what value I can add to that. |
Author
|
On the other hand, anyone can open a github repo, so I'm not sure what value I can add to that.
Fair enough - I picked this repo as a way to centralize the knowledge, but I did not mean to take on the responsibility for the historical work upon myself.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Went through the changes and tried to split them into logical commits for a clearer overview. Mostly succeeded, but there's two commits which I don't quite understand, marked them as such by prefixing the commit title with
?.This revealed the upstream changelog omits/skips on detail on the following changes:
install_prefixhas been renamed toDESTDIRconfigureoptions are deprecated:--with-gles,--with-glx,--without-setuid-hacksmake install-pamnow patches the packagedxscreensaver.pamusing files in the build machine's PAM configurationSome of the more notable commits:
make: rename
install_prefix->DESTDIRmake: delete old
PREFERRED_DEMOin all casesAlthough, this should just be done by pulling the
rmout of the conditionalmake: warn/error on deprecated/disliked configs
Error:
--with-gles--with-glxbreaks GLSLWarn:
--without-setuid-hacksbreaks hacks/sonar (jwz: for no good reason)make: Fix PAM patching logic
Pick up patches from build system's
PAM_DIR, instead of package chroot'sPAM_DIR(which will generally be empty)Of course, advisedness of such build system dependence is left as an exercise to the reader
app-defaults: use xdg commands (more generic)
Add unitary debian package
jwz dislikes debian fragmenting the package
hacks/xscreensaver-getimage: store url/title in xattrs
xattrsupport detection added to Makefile? Fix Wayland support
Ran out of time trying to figure this one out, pushed all Wayland-touching code into this commit
utils: Extract double_time, easing to libs
xscreensaver: fix block until input logic
Looks like a typo inverted the
tv.tv_usec == 0test? Don't know this code? hacks/glx/endgame: make animations fancier, add more famous endgames
At least, I think this is what this rewrite is trying to accomplish?
hacks/bsod: simplify logic
hacks/glx/glslideshow: Rewrite
Probably this is one of the
cases mentioned in the upstream changelog, but couldn't quite figure it out.
Removes the credit for the 2003 rewrite from Mike Oliphant for no clear reason.
hacks/glx/texfont: Fix on iOS
iOS lacks support for some OpenGL APIs, skip them
trans: Add Georgian translation