Fix grid2demand import - #1166
Open
pdobacz wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1132
The issue was related to FilePicker not returning a path but rather just the filename. That fix is split into 2 commits: one ensures that filename is used for cases where only the filename was relevant (dialogs). The other modifies FilePicker to return a path. IIUC it may not work with non-UTF8 characters in paths on Windows (� will be used), but neither would the original code. Fixing non-UTF8 paths requires changes to
abstio.After that, another issue prevented the file from #1132 being imported - lack of whitespace handling in LINESTRING entries in the input csv, which the 3rd commit fixes.
I clicked through import dialogs I could find, and things seem to work with the exception of KML - before my change it suffered from the same FilePicker issue, after the change it breaks on KML format itself.
DISCLAIMER: I'm relatively new to Rust, so pls do extra scrutiny on this one