Fix JavaScript function name validation#1400
Open
akfaew wants to merge 1 commit into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Updates JavaScript function-name validation to correctly accept single-character identifiers and dot-separated identifier chains, with expanded tests to cover more valid/invalid cases.
Changes:
- Refined the
jsFunctionNameregular expression to better match JavaScript identifier chains (e.g.,console.log). - Added additional unit test cases for edge conditions (single-character identifiers, malformed dot usage, leading digits).
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| scripttemplate.go | Tightens and corrects the regex used to validate permitted JS “function names”/paths. |
| js_test.go | Expands test matrix to cover previously missed valid/invalid inputs. |
| @@ -147,4 +147,4 @@ func jsonEncodeParam(param any) string { | |||
| } | |||
|
|
|||
| // isValidJSFunctionName returns true if the given string is a valid JavaScript function name, e.g. console.log, alert, etc. | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes JavaScript function name validation used by JSFuncCall.
The previous regexp rejected valid one-character identifiers like a, $, and _, while allowing invalid dotted names such as console.. This updates the validation to accept dot-separated JavaScript identifiers and reject empty, leading, or trailing member segments.
Tests
go test -run 'TestJS(FunctionNameRegexp|FuncCall)' .