feat: Add ElseRange to IfExpression and ContentsRange to RawElement#1402
Open
whalenrp wants to merge 1 commit into
Open
feat: Add ElseRange to IfExpression and ContentsRange to RawElement#1402whalenrp wants to merge 1 commit into
whalenrp wants to merge 1 commit into
Conversation
This adds two additional ranges, following the pattern of the prior
diffs to expand the AST.
**ElseRange** records the source range of the "} else {" keyword on
IfExpression. The field is empty when no else clause is present.
**ContentsRange** records the range of the text content inside a
RawElement, from the first byte after the open tag to
the byte immediately before the closing tag.
Both fields follow the Range-field convention started with a-h#586
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds two additional ranges, following the pattern of the prior diffs to expand the AST.
ElseRange records the source range of the "} else {" keyword on IfExpression. The field is empty when no else clause is present.
ContentsRange records the range of the text content inside a RawElement, from the first byte after the open tag to the byte immediately before the closing tag.
Both fields follow the Range-field convention started with #586