Security: No server-side validation that sender belongs to target conversation/world#296
Open
tuanaiseo wants to merge 1 commit into
Conversation
The `writeMessage` mutation inserts a message for arbitrary `worldId` and `conversationId` values without checking that the conversation exists in that world and that the sending player is an active participant. This enables unauthorized message injection across conversations/worlds. Affected files: messages.ts Signed-off-by: tuanaiseo <221258316+tuanaiseo@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
writeMessagemutation inserts a message for arbitraryworldIdandconversationIdvalues without checking that the conversation exists in that world and that the sending player is an active participant. This enables unauthorized message injection across conversations/worlds.Severity:
highFile:
convex/messages.tsSolution
Before inserting, load the world/conversation state and verify: (1) conversation exists in
worldId, (2) sender is an active participant, and (3) sender is authorized user identity. Reject on any mismatch.Changes
convex/messages.ts(modified)Testing