fix: add WASM-compatible retry mechanism for RPC requests#481
Closed
DeVikingMark wants to merge 9 commits intoa16z:masterfrom
Closed
fix: add WASM-compatible retry mechanism for RPC requests#481DeVikingMark wants to merge 9 commits intoa16z:masterfrom
DeVikingMark wants to merge 9 commits intoa16z:masterfrom
Conversation
was sleepy and accidentally wrote comments not on english
ncitron
reviewed
Jan 6, 2025
| @@ -0,0 +1,76 @@ | |||
| use std::time::Duration; | |||
Collaborator
There was a problem hiding this comment.
It seems that this is not in the right directory so isn't even being compiled? Should be in src/execution/rpc.
Collaborator
|
This has been resolved as of #484 since alloy's retries work in wasm as of the latest updates. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #407
Added WASM-compatible retry mechanism for RPC requests to replace non-working Alloy retry implementation.
Changes made:
This fixes the issue where RPC retries would fail when compiled to WebAssembly.