chore: update alloy version to 9.0#485
Conversation
Wiz Scan Summary
To detect these findings earlier in the dev lifecycle, try using Wiz Code VS Code Extension. |
| Transaction { | ||
| inner: inner_tx, | ||
| deposit_nonce, | ||
| deposit_receipt_version: None, |
There was a problem hiding this comment.
I've left it as None for now. Or do we want to implement a check for Canyon fork in scope of this PR?
There was a problem hiding this comment.
I think we should assume that Canyon has been activated for now as all the superchain chains have already gone through that hard fork. Alternatively we can add the canyon time to the config so we can be smart about what to set this field.
Either way, I think setting it to None as the default is probably not the right choice as Canyon is already enabled.
There was a problem hiding this comment.
Maybe I went the wrong way here.
I used op-alloy's Transaction struct that has deposit_nonce and deposit_receipt_version fields.
While deposit_receipt_version would be easy with known block number, I think I used a wrong nonce -- the correct one is in the receipt, not envelope. And I'm not sure how to get receipt's data here.
Maybe this is why you used the alloy's generic Transaction in the first place and we should stick with it? What do you think?
There was a problem hiding this comment.
Hmm it seems there actually isn't even a way to extract the correct deposit nonce anyway, which is pretty unfortunate. I guess we can leave as is for now.
ncitron
left a comment
ncitron
left a comment
There was a problem hiding this comment.
Looking good. Just one thought on the Canyon stuff.
| Transaction { | ||
| inner: inner_tx, | ||
| deposit_nonce, | ||
| deposit_receipt_version: None, |
There was a problem hiding this comment.
I think we should assume that Canyon has been activated for now as all the superchain chains have already gone through that hard fork. Alternatively we can add the canyon time to the config so we can be smart about what to set this field.
Either way, I think setting it to None as the default is probably not the right choice as Canyon is already enabled.
2 participants
This is my take on issue #484 . I tried to keep it as simple as possible without any rework of underlying structure.
Key changes:
alloycrates have been updated to latest version of9.0Some breaking changes are likely to be introduced because of change
TransactionRequest->OpTransactionRequesttype for OPStack.I invite anyone interested to review and regression test this PR, feedback is much appreciated. I'd be happy to fix whatever has to be fixed.