refactor(builder): improve error handling in URL parsing#504
Closed
VolodymyrBg wants to merge 1 commit intoa16z:masterfrom
VolodymyrBg:VolodymyrBg
Closed
refactor(builder): improve error handling in URL parsing#504VolodymyrBg wants to merge 1 commit intoa16z:masterfrom VolodymyrBg:VolodymyrBg
VolodymyrBg wants to merge 1 commit intoa16z:masterfrom
VolodymyrBg:VolodymyrBg
Conversation
Commit Description: Replace unwrap() calls with proper error handling in OpStackClientBuilder. This change makes the builder more robust by: - Converting consensus_rpc and execution_rpc methods to return Result - Using the ? operator for proper error propagation - Preventing potential panics from invalid URLs This improves the reliability and safety of the client builder pattern.
Contributor
Author
Collaborator
|
We do not accept these types of changes (minor code style) at this time |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit Description:
Replace unwrap() calls with proper error handling in OpStackClientBuilder. This change makes the builder more robust by:
This improves the reliability and safety of the client builder pattern.