Skip to content

fix: send blocks before signaling sync complete #725

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncitron merged 1 commit into from
Oct 27, 2025
Merged

fix: send blocks before signaling sync complete #725

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion ethereum/consensus-core/tests/runner/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ fn get_forks(with_electra: bool) -> Forks {
epoch: if with_electra { 0 } else { u64::MAX },
fork_version: fixed_bytes!("05000001"),
},
fusaka: Fork {
fulu: Fork {
epoch: u64::MAX,
fork_version: fixed_bytes!("06000001"),
},
Expand Down
2 changes: 1 addition & 1 deletion ethereum/src/consensus.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -167,8 +167,8 @@ impl<S: ConsensusSpec, R: ConsensusRpc<S>, DB: Database> ConsensusClient<S, R, D
}
}

_ = sync_status_send.send(ConsensusSyncStatus::Synced);
_ = inner.send_blocks().await;
_ = sync_status_send.send(ConsensusSyncStatus::Synced);

let start = Instant::now() + inner.duration_until_next_update().to_std().unwrap();
let mut interval = interval_at(start, std::time::Duration::from_secs(12));
Expand Down
4 changes: 2 additions & 2 deletions tests/rpc_equivalence.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -931,7 +931,7 @@ async fn test_get_balance_zero_address(

async fn test_get_code_eoa_address(helios: &RootProvider, expected: &RootProvider) -> Result<()> {
let block_num = helios.get_block_number().await?;
let eoa_address = address!("d8dA6BF26964aF9D7eEd9e03E53415D37aA96045"); // vitalik.eth
let eoa_address = address!("4838B106FCe9647Bdf1E7877BF73cE8B0BAD5f97");

let code = helios
.get_code_at(eoa_address)
Expand All @@ -949,7 +949,7 @@ async fn test_get_code_eoa_address(helios: &RootProvider, expected: &RootProvide
code.len()
);
if !code.is_empty() {
return Err(eyre::eyre!("EOA should have empty code"));
return Err(eyre::eyre!("EOA should have empty code. Found: {}", code));
}
Ok(())
}
Expand Down
Loading