feat(cli): time CDC transform stage separately from send - #188
Open
aatran14 wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
why
The transform/embed stage is the dominant cost of interest in the CDC pipeline i.e. the embedding round trip. But currently it has no means of being recorded.
So far the system does an excellent job of keeping the measurements simple and concise like:
This PR entertains the integration of transform cost. Thus, we could measure
transform / total timeto measure how much the transform is soaking the CDC pipeline.add
observability.rs:cdc_transform_duration: Histogram<f64>onMetrics, built aspuffgres.cdc.transform_duration_msinbuild_metricsstreaming.rs: wraptransform_batchinprocess_config_eventswithInstant::now()and record elapsed ms into that histogramLive CDC only. Backfill is not covered yet (
core::run_backfilltakes no metrics param). Observability only, so no behavior change.testing stuff
cargo check -p puffgres-cliandcargo test -p puffgres-clitransform_duration_msappears alongside the other CDC metrics--provider none. The reason why this check make sense is when a real embedding provider is wired up, the transform makes the network call to the embedding model, which takes O(us)-O(ms) depending on regional overhead. Decoding the row is microseconds (us). The turbopuffer write is also a network call and is already measured viaturbopuffer_latency