feat: Revert code that enforces uuid structure on context id in tasks #429
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Summary of Changes
Hello @pstephengoogle, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request primarily reverts a previous change that enforced a UUID structure on the context_id during task creation, providing greater flexibility for task identifiers. Additionally, it includes significant refactoring in proto_utils.py to improve the handling of Protocol Buffer Struct conversions and introduces support for agent extensions within capability definitions.
Highlights
- Revert UUID Enforcement: The core change in this PR is the removal of the validation logic that enforced a UUID structure on the
context_idwhen creating new tasks. This allows for more flexiblecontext_idvalues. - Protocol Buffer Conversion Refactoring: The
proto_utils.pyfile has been refactored to streamline the conversion between Python dictionaries and Protocol Bufferstruct_pb2.Structobjects. This includes the introduction of a newdict_to_structhelper function and the adoption ofjson_format.MessageToDictfor reverse conversions. - Agent Extension Support: New functionality has been added to support agent extensions within the
AgentCapabilitiesproto conversions, allowing for more detailed descriptions and parameters for agent capabilities.
Using Gemini Code Assist
The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.
Invoking Gemini
You can request assistance from Gemini at any point in your pull request via creating an issue comment (i.e. comment on the pull request page) using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands.
| Feature | Command | Description |
|---|---|---|
| Code Review | /gemini review |
Performs a code review for the current pull request in its current state. |
| Pull Request Summary | /gemini summary |
Provides a summary of the current pull request in its current state. |
| Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in issue comments and review comments. |
| Help | /gemini help |
Displays a list of available commands. |
Customization
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.
Limitations & Feedback
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.
You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.
Footnotes
-
Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩
There was a problem hiding this comment.
Code Review
This pull request reverts the enforcement of UUID format for context_id in task creation, which aligns with the stated goal. Additionally, it introduces several improvements for converting between Python dictionaries and Protobuf Struct messages, making the code more robust by supporting various data types instead of just strings. The changes are well-implemented. I have one suggestion to simplify the new dict_to_struct utility function by using a built-in method, which would make it more concise and efficient.
|
Looks like there's a unit test error: |
🤖 I have created a release *beep* *boop* --- ## [0.3.3](v0.3.2...v0.3.3) (2025-08-22) ### Features * Update proto conversion utilities ([#424](#424)) ([a3e7e1e](a3e7e1e)) ### Bug Fixes * fixing JSONRPC error mapping ([#414](#414)) ([d2e869f](d2e869f)) * Revert code that enforces uuid structure on context id in tasks ([#429](#429)) ([e3a7207](e3a7207)), closes [#427](#427) ### Performance Improvements * optimize logging performance and modernize string formatting ([#411](#411)) ([3ffae8f](3ffae8f)) ### Reverts * Revert "chore(gRPC): Update a2a.proto to include metadata on GetTaskRequest" ([#428](#428)) ([39c6b43](39c6b43)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Reverts enforcement of uuid on context_id in task creation
Fixes #427
Release-As: 0.3.3