-
Notifications
You must be signed in to change notification settings - Fork 303
fix: disable stream for helloworld example, since it do not support #53
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: disable stream for helloworld example, since it do not support #53
Conversation
Signed-off-by: vincent-pli <[email protected]>
|
@vincent-pli I have to revert this PR. Can you please let me know where you are seeing this error? Invoking message/stream request should the string |
|
@kthota-g |
|
@vincent-pli send_message_streaming returns an AsyncGenerator, which is not awaitable. Here is an example for how you can process the response - https://github.com/google/a2a-python/blob/53a58611b32bc3ae01adba432463d1d5cab95f09/examples/helloworld/test_client.py#L33 |
|
You are right, my mistake, thanks a lot |
|
However, in the
|
…oject#53) Signed-off-by: vincent-pli <[email protected]> Co-authored-by: Holt Skinner <[email protected]>
a2aproject#53)" (a2aproject#55) This reverts commit 436c931.
Description
Thank you for opening a Pull Request!
Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
CONTRIBUTINGGuide.nox -s formatfrom the repository root to format)Fixes #<issue_number_goes_here> 🦕
The
helloworldexample do not act as stream enable, so I get exceptionwhen I try to invoke
client.send_message_streaming