Skip to content

Conversation

@yarolegovich
Copy link
Member

@yarolegovich yarolegovich commented Nov 7, 2025

Extended client.send_message to take metadata parameter which gets attached to MessageSendParams.

BEGIN_COMMIT_OVERRIDE
fix: add metadata to send message request
END_COMMIT_OVERRIDE

@yarolegovich yarolegovich requested a review from a team as a code owner November 7, 2025 10:50
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @yarolegovich, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request introduces a significant enhancement by enabling the attachment of custom metadata to messages sent through the client.send_message interface. This provides a flexible mechanism for extending message capabilities without altering core message structures, allowing for more contextual and dynamic message processing.

Highlights

  • New Feature: Message Metadata: The client.send_message function now accepts an optional request_metadata parameter, allowing users to attach arbitrary key-value data to outgoing messages.
  • Parameter Propagation: The provided request_metadata is passed through to the MessageSendParams object, ensuring it is associated with the message sending request.
  • API Updates: The send_message function signatures in both src/a2a/client/base_client.py and src/a2a/client/client.py have been updated to include the new request_metadata parameter.
  • Test Coverage: New test cases have been added to tests/client/test_base_client.py to verify that the request_metadata is correctly handled and attached for both streaming and non-streaming message scenarios.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request successfully adds a metadata parameter to the send_message method, propagating it to MessageSendParams. The changes are implemented correctly in both the abstract Client and the BaseClient implementation. The tests have been updated to verify this new functionality in both streaming and non-streaming modes. My feedback includes a couple of minor stylistic suggestions to improve code conciseness in the test files.

@herczyn herczyn merged commit 12b4a1d into a2aproject:main Nov 7, 2025
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants