fix: null-pointer when message send configuration is provided with no history limit

[yarolegovich]

Fixes a null pointer when message send configuration is provided with no history limit.

[gemini-code-assist]

Summary of Changes

Hello @yarolegovich, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a critical null-pointer exception that could arise during message processing when the history length configuration was not explicitly defined. By implementing a robust check for the presence of a history limit, the change enhances the stability and reliability of the message sending mechanism, preventing unexpected application crashes in such scenarios.

Highlights

• Null Pointer Fix: Addressed a null-pointer exception that occurred when MessageSendConfiguration was provided without a history_length limit, by ensuring history_length is explicitly checked for None before being used.
• New Test Case: Introduced a new asynchronous test case, test_on_message_send_limit_history_non_as_no_limit, to specifically validate the fix and ensure that message sending works correctly when history_length is set to None.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request addresses a potential null pointer issue when message send configuration is provided without a history limit, and adds a new test case to cover this scenario. The fix in default_request_handler.py is effective, but the added condition is redundant as the called function apply_history_length already handles the None case gracefully. I've suggested a simplification to avoid this redundancy. Additionally, I've proposed a more descriptive name for the new test to improve clarity.

[gemini-code-assist]

While this change is intended to fix a null-pointer issue, the check for params.configuration.history_length is not None appears to be redundant. The apply_history_length function already includes a check for history_length is not None and safely handles the case where it is None by returning the task unmodified.

To avoid duplicating this logic and to keep the code cleaner, it would be better to rely on apply_history_length to handle this. This centralizes the logic for handling history_length values.

Suggested change

	if params.configuration and params.configuration.history_length is not None:
	if params.configuration:

[gemini-code-assist]

This is a great test case to ensure that a None value for history_length doesn't truncate the history. For better readability, consider renaming the test to be more descriptive of its purpose. For example: test_on_message_send_with_none_history_length_is_not_limited.

Suggested change

	async def test_on_message_send_limit_history_non_as_no_limit():
	async def test_on_message_send_with_none_history_length_is_not_limited():