-
Notifications
You must be signed in to change notification settings - Fork 303
ci(scripts): add version support to generate_types.sh #539
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
- Add A2A_SPEC_VERSION environment variable (default: v0.3.0) - Support version specification via --version flag - Auto-detect version type (tag/branch/commit SHA) - Add URL validation before generating types - Improve error messages and usage documentation - Add input file existence validation Signed-off-by: Luca Muscariello <[email protected]>
Summary of ChangesHello @muscariello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces version support to the generate_types.sh script, a valuable enhancement for decoupling the SDK from the A2A specification repository. The implementation is solid, adding an environment variable and a command-line flag for version control, along with URL validation and much-improved usage documentation. My review includes a few minor suggestions to enhance the script's maintainability and readability.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
Signed-off-by: Luca Muscariello <[email protected]>
Description
Adds version support to generate_types.sh to decouple the A2A specification repository from the SDK repository.
Changes
Usage
Testing