Skip to content

Conversation

@vinoo999
Copy link

@vinoo999 vinoo999 commented Nov 19, 2025

Description

allow.txt is currently case insensitive. The formatting script does a case sensitive reformat introducing inconsistent formatting on running appropriate linting scripts. Addresses independent comment made: https://github.com/a2aproject/a2a-python/pull/522/files#r2538970891

  • Follow the CONTRIBUTING Guide.
  • Make your Pull Request title in the https://www.conventionalcommits.org/ specification.
    • Important Prefixes for release-please:
      • fix: which represents bug fixes, and correlates to a SemVer patch.
      • feat: represents a new feature, and correlates to a SemVer minor.
      • feat!:, or fix!:, refactor!:, etc., which represent a breaking change (indicated by the !) and will result in a SemVer major.
  • Ensure the tests and linter pass (Run bash scripts/format.sh from the repository root to format)
  • Appropriate docs were updated (if necessary)

@vinoo999 vinoo999 requested a review from a team as a code owner November 19, 2025 06:02
@gemini-code-assist
Copy link
Contributor

Summary of Changes

Hello @vinoo999, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the scripts/format.sh script by modifying the sorting behavior for the SPELLING_ALLOW_FILE. The change introduces case-insensitive sorting, which improves the consistency and accuracy of the spelling allowlist by treating entries with different casing as the same during sorting and de-duplication. This addresses a specific comment and enhances the script's robustness.

Highlights

  • Case-Insensitive Sorting: The sort command used within scripts/format.sh for the SPELLING_ALLOW_FILE has been updated to perform a case-insensitive sort. This ensures that entries like 'Word' and 'word' are treated as identical for de-duplication purposes.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@vinoo999 vinoo999 changed the title Update sort command to be case-insensitive chore: Update sort command to be case-insensitive Nov 19, 2025
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The change to make the sort command case-insensitive in scripts/format.sh is correct and well-implemented. Adding the -f flag is the right approach to ensure the spelling allow list is de-duplicated regardless of case. This is a good improvement, and I have no further suggestions.

@vinoo999 vinoo999 changed the title chore: Update sort command to be case-insensitive chore(ci): Update sort command to be case-insensitive Nov 19, 2025
@holtskinner
Copy link
Member

This was intentionally left case-sensitive, because the case-insensitive sort wasn't always consistent.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants