Skip to content

added mb_ pollyfils and added a test suite to ensure it still works#172

Merged
gin0115 merged 13 commits into
trunkfrom
feature/add-mb-string-pollyfills
Jul 8, 2025
Merged

added mb_ pollyfils and added a test suite to ensure it still works#172
gin0115 merged 13 commits into
trunkfrom
feature/add-mb-string-pollyfills

Conversation

@gin0115

@gin0115 gin0115 commented Jul 8, 2025

Copy link
Copy Markdown
Collaborator

Changes proposed in this Pull Request

This pull request introduces changes to improve compatibility with PHP environments that may lack the mbstring extension. It updates the CI workflow to handle cases where mbstring is unavailable and adds polyfills for mb_strimwidth and mb_strlen in functions.php. These changes ensure functionality even in environments without mbstring.

CI Workflow Updates:

  • .github/workflows/unit-tests.yml: Modified the matrix strategy to include a special case for PHP 8.3 without the mbstring extension. Updated the setup step to dynamically configure PHP and extensions based on the matrix values. [1] [2]

Polyfills for Missing Functions:

  • functions.php: Added polyfills for mb_strimwidth and mb_strlen to provide fallback implementations when the mbstring extension is not available. These polyfills ensure compatibility and graceful degradation.

Testing instructions

Mentions #

Summary by CodeRabbit

  • New Features

    • Added polyfill implementations for mb_strimwidth and mb_strlen functions to improve compatibility in environments without native multibyte string support.
  • Chores

    • Updated test workflow to conditionally install the mbstring PHP extension based on PHP version and display the current PHP version during testing.
    • Improved test coverage by verifying availability of multibyte string functions and updated test syntax for better consistency.

@coderabbitai

coderabbitai Bot commented Jul 8, 2025

Copy link
Copy Markdown

Warning

Rate limit exceeded

@gin0115 has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 8 minutes and 19 seconds before requesting another review.

⌛ How to resolve this issue?

After the wait time has elapsed, a review can be triggered using the @coderabbitai review command as a PR comment. Alternatively, push new commits to this PR.

We recommend that you space out your commits to avoid hitting the rate limit.

🚦 How do rate limits work?

CodeRabbit enforces hourly rate limits for each developer per organization.

Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout.

Please see our FAQ for further information.

📥 Commits

Reviewing files that changed from the base of the PR and between 0ffc9fb and 8a497fb.

📒 Files selected for processing (1)
  • tests/Test_Functions.php (1 hunks)

Walkthrough

The GitHub Actions workflow for unit tests was updated by renaming the PHP versions matrix key from php-versions to php and limiting the tested PHP versions to 8.1 through 8.4. The PHP setup step was modified to conditionally install the mbstring extension only when the PHP version is not 8.1 by dynamically setting the extensions input. A new step was added immediately after PHP setup to output the current PHP version using php -v. In the PHP codebase, polyfill implementations for the mb_strimwidth and mb_strlen functions were added to provide these multibyte string functions if they do not already exist. Additionally, a new test method was added to verify the availability of these functions, and an existing test method was updated to use get_class() for retrieving class names and short array syntax. No other exported or public entities were modified.


Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@gin0115 gin0115 merged commit 606d5b5 into trunk Jul 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant