Fix/correctly encode urls to avoid issues with slashes

[gin0115]

Changes proposed in this Pull Request

This pull request updates the URL normalization logic to ensure consistent encoding across various components and adjusts the associated tests to reflect these changes. The most important changes include modifications to the wpcomsp_wayback_link_fixer_normalize_url function, updates to the wpcomsp_wayback_link_fixer_is_current_site_link function, and adjustments to test cases to align with the new encoding behavior.

URL Normalization Enhancements:

• Updated wpcomsp_wayback_link_fixer_normalize_url to apply rawurlencode to the entire path and the host, ensuring all URLs are consistently encoded. (functions.php, [1] [2]

URL Comparison Logic:

• Modified wpcomsp_wayback_link_fixer_is_current_site_link to normalize all site URLs before comparison, ensuring accurate matching against encoded URLs. (functions.php, functions.phpR405-R407)

Test Updates for URL Encoding:

• Adjusted test cases in Test_Functions to validate the new encoding format for normalized URLs, including paths, query parameters, and special characters. (tests/Test_Functions.php, tests/Test_Functions.phpL27-R39)
• Updated tests in Test_HTTP_Link_Checker_Client to check for encoded URLs in API requests. (tests/Wayback_Machine/Test_HTTP_Link_Checker_Client.php, [1] [2]
• Revised tests in Test_HTTP_Snapshot_Client to verify that encoded URLs are used in various scenarios, such as filters and API calls. (tests/Wayback_Machine/Test_HTTP_Snapshot_Client.php, [1] [2] [3]

Testing instructions

Mentions #

Summary by CodeRabbit

• Bug Fixes

  • Improved URL normalization to ensure consistent and accurate encoding across all site and snapshot links.

• Tests

  • Updated test cases to expect fully percent-encoded URLs, ensuring alignment with the new URL normalization logic.

[coderabbitai]

Caution

Review failed

The pull request is closed.

Walkthrough

The changes update the URL normalization logic in the wpcomsp_wayback_link_fixer_normalize_url function to apply percent-encoding to the entire scheme, host, and path portions of URLs, rather than encoding only individual path segments. This affects how URLs are compared and processed within the plugin. Corresponding updates were made to unit tests, adjusting expected outcomes and assertions to match the new normalization approach, with all relevant test cases now expecting fully percent-encoded URLs. No changes were made to the signatures of public functions or exported entities; all modifications are internal or related to test expectations.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Free

📥 Commits

Reviewing files that changed from the base of the PR and between 606d5b5 and 10a1ee9.

📒 Files selected for processing (4)

• functions.php (3 hunks)
• tests/Test_Functions.php (1 hunks)
• tests/Wayback_Machine/Test_HTTP_Link_Checker_Client.php (2 hunks)
• tests/Wayback_Machine/Test_HTTP_Snapshot_Client.php (3 hunks)

---

Note

🎁 Summarized by CodeRabbit Free

Your organization is on the Free plan. CodeRabbit will generate a high-level summary and a walkthrough for each pull request. For a comprehensive line-by-line review, please upgrade your subscription to CodeRabbit Pro by visiting https://app.coderabbit.ai/login.

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Explain this complex logic.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai explain this code block.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and explain its main purpose.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Join our Discord community for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.