This repository was archived by the owner on Oct 23, 2025. It is now read-only.
Added option to use slug instead of name as a key in netbox dict - #6
Open
bdlamprecht wants to merge 3 commits into
Open
Added option to use slug instead of name as a key in netbox dict #6bdlamprecht wants to merge 3 commits into
slug instead of name as a key in netbox dict #6bdlamprecht wants to merge 3 commits into
Conversation
Owner
|
Cool, could you please check the failed tests? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is my first Git "Fork / Pull" request so I apologize if I didn't follow protocol.
I implemented an option to to use
slugas the key in netbox as I requested in issue #4.Also, I thought it would be nice to add the
--versiontoargparseto keep a handle on the progression of this code.Feel free to change the variable names and comments I used in the
netbox.ymlfile or even the entire method. I'm not a developer by trade, so again, sorry in advance.