fix: handle upstream titleBarStyle change for About window#489
Open
Hayao0819 wants to merge 1 commit intoaaddrick:mainfrom
Open
fix: handle upstream titleBarStyle change for About window#489Hayao0819 wants to merge 1 commit intoaaddrick:mainfrom
Hayao0819 wants to merge 1 commit intoaaddrick:mainfrom
Conversation
Upstream changed the About window's titleBarStyle from "" to "hiddenInset", causing isPopupWindow() to misclassify it as the main window. This resulted in frame: true and resize handlers being applied to the About dialog, breaking its rendering on GNOME/X11 (showing minified JS instead of version info). Update isPopupWindow() to also match titleBarStyle === 'hiddenInset' for windows without minWidth. Fixes aaddrick#481
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
titleBarStylefrom""to"hiddenInset", causingisPopupWindow()to no longer recognize it as a popupframe: trueand resize handlers, which broke its rendering on GNOME/X11 (showed minified JS instead of version info)isPopupWindow()to also matchtitleBarStyle === 'hiddenInset'for windows withoutminWidthTest plan
claude-desktopon GNOME/X11 with default menu bar mode (auto)Follow-up
Since this fix makes the About window frameless (
frame: false), there is no native close button. A follow-up PR to add Escape key support for closing popup windows is ready atfix/popup-escape-close.Fixes #481