-
Notifications
You must be signed in to change notification settings - Fork 4.4k
fix(providers): fall back to configured models when models endpoint fetch fails #7530
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 7 commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
9e751a3
fix(providers): fallback to predefined models when API fetch fails
octogonz 4e38b52
fix(providers): only fallback to custom models for endpoint-not-imple…
octogonz a3e8896
fix(providers): narrow fallback to 404 only, not connection failures
octogonz 5418324
fix(providers): use (404) pattern to avoid false port matches
octogonz 5a9936f
chore: remove restatement comments from fetch_supported_models fallback
073cc65
Merge remote-tracking branch 'origin/main' into pr-7530
39181a5
fix(providers): use EndpointNotFound variant for 404 instead of subst…
6c756b5
fix(providers): scope EndpointNotFound to models endpoint, keep Reque…
8a61304
Merge remote-tracking branch 'origin/main' into pr-7530
0bf7e87
chore: update generated OpenAPI types after merge with main
97b271a
Merge remote-tracking branch 'origin/main' into pr-7530
55be883
Merge remote-tracking branch 'origin/main' into pr-7530
22703f2
chore: regenerate OpenAPI types with current codegen version
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mapping every
404toEndpointNotFoundhere regresses the model-recommendation flow for failed inference calls.Agent::enhance_model_errorinagents/reply_parts.rsonly augmentsProviderError::RequestFailedwith “available models” suggestions, so a/chat/completionsresponse like “model ... not found” now skips that path and surfaces a less actionable generic error. This is a user-visible regression from the previousRequestFailedmapping for 404 responses.Useful? React with 👍 / 👎.