feat(desktop): add zh-CN localization support#7701
feat(desktop): add zh-CN localization support#7701sysusugan wants to merge 1 commit intoaaif-goose:mainfrom
Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 728172b32d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
728172b to
bbd8f26
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: bbd8f268f0
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
bbd8f26 to
1d04eb1
Compare
|
I also noticed #7599 is open in the same area. This PR is intentionally optimized for depth rather than breadth. Instead of starting with a broader localization framework, it focuses on delivering a polished
The goal here is not just to add a small amount of Chinese text, but to make the Chinese desktop experience feel complete, natural, and genuinely usable for real adoption. If maintainers would prefer a single direction, I’m happy to align, narrow this further, or rework it to fit the preferred approach. |
|
I like this, but I would like to double check with folks like @DOsinga |
|
very nice! /goose can we have a deep review of how idiomatic these changes are pls |
|
I’m a Chinese user, and I’d really like to see Chinese localization support in Goose. I merged this PR locally and tried it for a bit, and the overall experience is great. Most of it feels natural and would be genuinely helpful for Chinese users. The only small thing that stood out to me was translating “deeplink” as “深链”. I’d personally suggest keeping “deeplink” in English. |
Thanks for trying this locally and for the thoughtful feedback. I agree that “深链” doesn’t feel quite right here. I’m thinking of changing it to “深度链接”, which reads more naturally to me while still preserving the technical meaning. If you have another wording in mind, I’d love to hear it. |
|
This change is heading in the right direction. It would be especially helpful if reviewers could focus on: 1) backward compatibility, 2) edge cases and fallback behavior, and 3) whether the naming and abstraction can be tightened further. If anyone has seen real-world issues in this part of the stack before, concrete examples would be very valuable here and would help make the merge much safer. 🚀🚀🚀 |
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
1d04eb1 to
b3b39c2
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b3b39c2785
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
b3b39c2 to
5d198cc
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5d198ccb1b
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
5d198cc to
fa64638
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fa64638c20
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
|
|
||
| initSession(); | ||
| }, [resourceUri, extensionName, workingDir, cachedHtml]); | ||
| }, [resourceUri, extensionName, workingDir, cachedHtml, t]); |
There was a problem hiding this comment.
This useEffect now depends on t, so any UI language update (including broadcasts from another window) reruns initSession() and calls startAgent/resumeAgent again even when a standalone app session is already running. That recreates the backend session and swaps sessionId, which can interrupt the active app view and churn agent processes unnecessarily. The session-init effect should be decoupled from translation function changes or guarded once a session exists.
Useful? React with 👍 / 👎.
| }); | ||
| } | ||
| }, [isOpen, sessionId, hasAnalyzed, form]); | ||
| }, [isOpen, sessionId, hasAnalyzed, form, t]); |
There was a problem hiding this comment.
Including t in this analysis effect dependency list means a language change while the modal is open and hasAnalyzed is still false will kick off a second createRecipe request and a second stage timer. Because the effect has no cleanup return, both async flows can run concurrently and race to overwrite the form fields, causing duplicate backend work and inconsistent prefilled recipe content.
Useful? React with 👍 / 👎.
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
fa64638 to
5448d53
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5448d53a71
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
5448d53 to
1b15e0f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1b15e0f33f
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
1b15e0f to
c35ac8f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c35ac8f069
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
c35ac8f to
2ba6b21
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2ba6b219d5
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
2ba6b21 to
268752f
Compare
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 268752f3f1
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
268752f to
8497b7a
Compare
|
I did another full pass on the desktop changes and fixed the remaining locale-change regressions I could find. At this point, the desktop localization work should be complete with respect to the issues surfaced in review, including menu/tray behavior, async reload paths, and modal/form state resets. I also re-ran the full desktop checks locally:
Result:
|
Signed-off-by: sysusugan <sugan@foxmail.com>
sysusugan
force-pushed
the
pr/desktop-zh-cn-localization-clean
branch
from
8497b7a to
3c5669a
Compare
|
Thanks for the effort here — adding zh-CN localization is a meaningful contribution and we appreciate the interest! However, we're going to close this PR for a few reasons:
For what it's worth, we've gone in a different direction for i18n — see #8105. If you'd like to contribute zh-CN translations within that framework, that would be very welcome as a follow-up! |
|
Thanks for the clear feedback — that makes sense. I understand this PR was too large for a first contribution, should have started with prior discussion, and didn’t land in the right shape for review. I still care about zh-CN support for Goose, so I’ll keep following the progress around #8105 and see whether there’s a useful way for me to contribute later on. |
8 participants
Motivation
This change aims to make Goose easier to adopt among Chinese-speaking developers by reducing the UI language barrier, while keeping English as the default experience.
Summary
zh-CNas a desktop UI language while keeping English as the defaultScope
ui/desktop)Implementation Notes
enandzh-CNlocale dictionariesLocalizationProviderand wire language selection into persisted desktop settingsHuggingFace,OAuth,API Key, and extension names/descriptionsValidation
cd ui/desktop && npm run typecheckcd ui/desktop && npm run test:runNotes
Screenshots
Examples of the
zh-CNdesktop experience, including settings, navigation, chat surfaces, and native desktop menus/tray UI.