feat: GenUI MCP service and Workspace coordination#7768
feat: GenUI MCP service and Workspace coordination#7768bioinfornatics wants to merge 1 commit intoaaif-goose:mainfrom
Conversation
GenUI Service (crates/goose-mcp/src/genui_service/ — 534 lines): - MCP server for generating UI components via LLM - Supports HTML/CSS/JS generation with structured output - KPI display, chart generation, data table rendering - Template-based component generation Workspace Coordination (crates/goose/src/execution/workspace.rs — 532 lines): - WorkspaceEventBus: broadcast channel for file/build/agent events - FileLockManager: advisory soft-locking for multi-agent file access - SharedWorkspace: combines event bus + file locks - WorkspaceEvent enum: FileChanged, BuildStarted, BuildCompleted, etc. - 16 unit tests Cherry-picked from feature/cli-via-goosed with zero adaptation needed. Signed-off-by: Jonathan MERCIER <bioinfornatics@gmail.com>
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 14c3cf2f3f
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
|
||
| pub mod autovisualiser; | ||
| pub mod computercontroller; | ||
| pub mod genui_service; |
There was a problem hiding this comment.
Adding genui_service as a module here does not make the new server runnable through Goose’s MCP entrypoints: McpCommand still only parses/dispatches autovisualiser, computercontroller, memory, and tutorial (in crates/goose-mcp/src/mcp_server_runner.rs, crates/goose-cli/src/cli.rs, and crates/goose-server/src/main.rs), so GenUiServiceServer cannot be launched by users and the feature is effectively unreachable.
Useful? React with 👍 / 👎.
| self.event_bus.publish(WorkspaceEvent::AgentLeft { | ||
| agent_id: agent_id.to_string(), | ||
| }); |
There was a problem hiding this comment.
leave always publishes WorkspaceEvent::AgentLeft even when agent_id was never joined (or leave is called twice), which can desynchronize consumers that derive presence from join/left events and cause false “agent disconnected” handling despite no real membership change.
Useful? React with 👍 / 👎.
|
thanks! this looks cool, probably overlaps somewhat with the goose-apps approach. then again, it is a standalone mcp server, no? so probably doesn't need to be bundled with goose |
2 participants
Summary
Adds two new modules:
GenUI MCP Service ()
Workspace Coordination ()
Files Changed
crates/goose-mcp/src/genui_service/mod.rs(+534 lines) — GenUI servicecrates/goose-mcp/src/lib.rs(+1 line) — module registrationcrates/goose/src/execution/mod.rs(+1 line) — module registrationcrates/goose/src/execution/workspace.rs(+532 lines) — workspace coordinationVerification