Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 30293388c5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 2e0aa82b57
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 760e99e625
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| set -euo pipefail | ||
|
|
||
| if [[ -z "${GOOSE_BIN:-}" ]]; then | ||
| export GOOSE_BIN="$(cargo metadata --format-version 1 | jq -r '.target_directory')/debug/goose" |
There was a problem hiding this comment.
The new default GOOSE_BIN value hardcodes <target_directory>/debug/goose, but cargo build -p goose-cli --bin goose produces goose.exe on Windows. In that environment, resolve_goose_binary() rejects the override because the path does not exist (ui/goose2/src-tauri/src/services/acp/goose_serve.rs checks GOOSE_BIN with path.exists()), so just dev/just dev-debug fail before the app can start unless users manually set GOOSE_BIN.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: fcfe90a46c
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if [[ -z "${GOOSE_BIN:-}" ]]; then | ||
| export GOOSE_BIN="$(cargo metadata --format-version 1 | jq -r '.target_directory')/debug/goose" | ||
| fi |
There was a problem hiding this comment.
This new block computes GOOSE_BIN from cargo metadata, but dev immediately overwrites it later with GOOSE_BIN="${PROJECT_DIR}/../../target/debug/goose", so the probe has no effect. Because the recipe runs with set -euo pipefail, any transient failure in cargo metadata/its parser aborts just dev even though the computed value is never used; the same pattern is duplicated in dev-debug.
Useful? React with 👍 / 👎.
2 participants
... with a just recipe to build from the repo root