-
Notifications
You must be signed in to change notification settings - Fork 4.5k
feat(goose2): inline edit & retry #8538
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 23 commits
Commits
Show all changes
34 commits
Select commit
Hold shift + click to select a range
e5dc709
feat: wire retry and edit buttons on user messages
tellaho 71a9323
fix: sync ChatInput text state when initialValue prop changes
tellaho 47d1154
fix: focus textarea when entering edit mode
tellaho 5eef949
feat: inline edit UX — edit message in-place with Save/Cancel
tellaho 7486ec5
feat: full-width inline edit with hinted background and info message
tellaho 0bdae1e
fix: stale closure, focus churn, dead draft write, dead i18n keys
tellaho 4ece14d
style: user bubble with bg-muted on content div, max-w-640px, no avatar
tellaho b7dcb1a
refactor: replace CSS group-hover with Radix HoverCard for message ac…
tellaho 5d6e8bf
fix: strip all visual chrome from HoverCard actions, add gap for overlap
tellaho 536d623
fix: restore Radix open/close animations on HoverCard actions
tellaho 18690e7
fix: add sideOffset to HoverCard actions for breathing room
tellaho 6a8567e
test: add inline edit tests and fix hover test for HoverCard
tellaho 553de5b
fix: guard handleSaveEdit against vanished messages
tellaho e5061bc
cleanup: HoverCard bare variant, dedup resize, gate edit state, es lo…
tellaho 2348e1e
fix: increase bottom padding so last message hover actions aren't cli…
tellaho 6456a76
fix: lower z-index on bare HoverCard so popovers/menus win
tellaho 2eecade
style: restyle inline edit action bar — default buttons, flipped layout
tellaho 79b2836
style: even padding on user message bubble
tellaho 4f68bb6
fix: retry/edit preserve attachments & persona, remove MessageBranch …
tellaho 143ab86
fix: address 3 review blockers — unify deferred sends, gate retry, na…
tellaho cbf6732
fix: preserve pathless browser-uploaded file attachments on retry/edit
tellaho 913932c
fix: update retry/edit tests to match new acpSendMessage signature (n…
tellaho a5d12c2
feat: truncate backend conversation on edit/retry via _meta.truncate_…
tellaho 39c6149
feat: wire truncate_before_message_id through frontend for edit/retry
tellaho def6cca
fix: sync message IDs between frontend and backend for edit/retry tru…
tellaho afa1c06
chore: downgrade truncation log from info to debug
tellaho c5aa09f
test: add unit tests for ThreadManager.truncate_from_message
tellaho 87bfe5a
fix: IME composition guard and queued-send race in edit flow
tellaho 4823251
fix: atomic truncation, precise boundary, and snapshot+restore
tellaho 103865b
fix: use .catch() instead of try/catch for async snapshot restore
tellaho c7e96ed
fix: guard Escape key against IME composition in inline edit
tellaho becf37f
fix: sync local message ID to backend via acpSendMessage
tellaho da05d60
fix: separate user message ID from assistant notification preset ID
tellaho 6e1d68d
debug: add tracing to on_prompt truncation path
tellaho File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.