align Goose2 MCP App rendering with tools/list metadata#8597
Closed
aharvard wants to merge 1 commit intofeat/mcp-app-view-bridge-bootstrapfrom
Closed
align Goose2 MCP App rendering with tools/list metadata#8597aharvard wants to merge 1 commit intofeat/mcp-app-view-bridge-bootstrapfrom
aharvard wants to merge 1 commit intofeat/mcp-app-view-bridge-bootstrapfrom
Conversation
This was referenced Apr 16, 2026
d14655b to
8c4b952
Compare
022b412 to
3551768
Compare
Signed-off-by: Andrew Harvard <aharvard@squareup.com>
3551768 to
ffcdb6a
Compare
Collaborator
Author
|
taking another route |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is PR 3 of 3 in a stacked PR sequence for MCP Apps in Goose2.
The full feature delivery depends on all three PRs merging. This PR stacks on PR 2, which itself stacks on PR 1.
The previous PR gets the inline app host working, but it still makes the render decision in a way that's more heuristic than we'd like. This PR moves that decision onto cached
tools/listmetadata, warms the catalog after session binding, and makesMcpAppViewmore renderer-only by passing it a resolved catalog entry instead of asking it to discover app linkage on its own.This is the cleanup and architectural alignment pass. It brings the code closer to the flow we documented:
tools/listis the source of truth for app linkage, and Goose2 only takes the inline app path when the matched catalog entry says it should.If you're reviewing this slice and want to see how it's supposed to work, start with the sequence diagram and notes in #8593.
Related to #8593.
Base PR: #8596.