-
Notifications
You must be signed in to change notification settings - Fork 4.4k
[goose2] MCP Apps: hydrate and replay app payloads in Goose2 #8632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aharvard
wants to merge
5
commits into
codex/translate-acp-host-capabilities
Choose a base branch
from
codex/mcp-apps-step2-tool-resource-association
base: codex/translate-acp-host-capabilities
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
2deb412
hydrate and replay mcp app payloads in goose2
aharvard c24a379
Fix replay MCP app payload handling
aharvard 6a3f0b8
Fix ToolResponse path in ACP server
aharvard 57cd30e
Fix Goose2 ACP notification state handling
aharvard b62e2f1
Fix Step 2 rebase merge typing issues
aharvard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,22 @@ | ||
| import { CodeBlock } from "@/shared/ui/ai-elements/code-block"; | ||
| import { useTranslation } from "react-i18next"; | ||
| import type { McpAppPayload } from "@/shared/types/messages"; | ||
|
|
||
| interface McpAppViewProps { | ||
| payload: McpAppPayload; | ||
| } | ||
|
|
||
| export function McpAppView({ payload }: McpAppViewProps) { | ||
| const { t } = useTranslation("chat"); | ||
|
|
||
| // Currently we just render the MCP App payload as JSON. | ||
| // Up next, we'll replace this with actual HTML rendering and host bridging. | ||
| return ( | ||
| <div className="my-3" data-testid="mcp-app-view"> | ||
| <div className="mb-2 text-muted-foreground text-xs uppercase tracking-wide"> | ||
| {t("message.mcpAppUnderConstruction")} | ||
| </div> | ||
| <CodeBlock code={JSON.stringify(payload, null, 2)} language="json" /> | ||
| </div> | ||
| ); | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In
resolve_tool, the new unconditionalget_all_tools_cached(session_id)call can fail before the prefixed fallback branch runs, so a valid call likeext__toolnow returns an internal error whenever tool listing fails (for example, due to an unrelated extension timing out). The previous behavior allowed prefixed tool calls to route directly to the owning client without requiring a successful global tool refresh, so this change makes dispatch reliability depend on list-tools health rather than call-tool availability.Useful? React with 👍 / 👎.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don’t think this reproduces with the current implementation. resolve_tool now intentionally checks the listed tool set first so prefixed calls still respect available_tools filtering and preserve MCP app metadata. Also, fetch_all_tools() already degrades individual list_tools failures to warnings/empty results, so unrelated extension timeouts don’t usually cause get_all_tools_cached() to fail before the prefixed fallback runs. The remaining coupling is only on a true top-level internal cache/list failure, which is much narrower than the scenario described.