Conversation
Set rust-version in the workspace Cargo.toml and propagate it to every member crate. Add a rust-msrv CI job that reads the MSRV out of Cargo.toml and runs cargo check --workspace --locked --all-targets against exactly that toolchain, so new dependencies that raise the floor fail CI instead of silently breaking downstream packagers. The floor today is driven by transitive deps (aws-smithy-xml 0.60.15 declares rust-version = 1.91.1, and several pctx_* / aws-smithy-* crates sit above 1.88). Signed-off-by: jh-block <jhugo@block.xyz>
jamadeo
approved these changes
Apr 21, 2026
spikewang
pushed a commit
to spikewang/goose
that referenced
this pull request
Apr 22, 2026
Signed-off-by: jh-block <jhugo@block.xyz>
lifeizhou-ap
added a commit
that referenced
this pull request
Apr 22, 2026
* main: feat: extend goose2 context window ux with auto-compaction (#8721) improve goose2 agent management flows (#8737) alexhancock/tui-improvements (#8736) fix: add strict:false to Responses API tools and gpt-5.4 to known models (#8636) persist and reliably apply chat model selection (#8734) merge goose-acp crate into goose (#8726) docs: AGENTS.md section on goose2 desktop backend architecture (#8732) feat: goose2 message bubble + action tray (#8720) consolidate provider ACP methods onto inventory (#8710) ci: declare and enforce MSRV of 1.91.1 (#8670) fix(ui): correct grammar in apps view description (#8668) (#8679) Stop load openai fast model for openapi compatible custom endpoint (#8644)
lifeizhou-ap
added a commit
that referenced
this pull request
Apr 22, 2026
* main: (41 commits) removed the specific code owner for documentation change (#8749) fix(providers): handle missing delta field in streaming chunks (#8700) refactor(providers): extract http_status module and rename handle_status_openai_compat (#8620) fix(providers/openai): accept streaming chunks with both reasoning fields (#8715) feat: associate threads with projects (#8745) upgrade goose sdk and tui to be compatible with the latest agentclientprotocol/sdk package (#8667) feat: extend goose2 context window ux with auto-compaction (#8721) improve goose2 agent management flows (#8737) alexhancock/tui-improvements (#8736) fix: add strict:false to Responses API tools and gpt-5.4 to known models (#8636) persist and reliably apply chat model selection (#8734) merge goose-acp crate into goose (#8726) docs: AGENTS.md section on goose2 desktop backend architecture (#8732) feat: goose2 message bubble + action tray (#8720) consolidate provider ACP methods onto inventory (#8710) ci: declare and enforce MSRV of 1.91.1 (#8670) fix(ui): correct grammar in apps view description (#8668) (#8679) Stop load openai fast model for openapi compatible custom endpoint (#8644) feat(hooks): add Husky git hooks for ui/goose2 (#8577) fix: links in chat could not be opened (#8544) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: infrastructure
User Impact: Distro packagers (Fedora, Debian, etc.) now have a documented minimum Rust version to target, and the project will no longer silently drift above it.
Problem: A Red Hat engineer packaging goose for Fedora hit a build failure because a transitive dependency had jumped its MSRV past Fedora's packaged rustc. goose had no declared MSRV and no CI enforcement, so any
cargo updatecould silently raise the floor and break downstream packagers without us noticing.Solution: Declare
rust-version = "1.91.1"in the workspaceCargo.toml(this matches the current effective floor, driven byaws-smithy-xml 0.60.15among others) and propagate it to every member crate. Add arust-msrvCI job that reads the version out ofCargo.tomland runscargo check --workspace --locked --all-targetsagainst exactly that toolchain, so MSRV violations fail CI on the offending PR. The version lives in one place; CI extracts it, so future bumps are a one-line change.File changes
Cargo.toml
Added
rust-version = "1.91.1"to[workspace.package]as the single source of truth for the MSRV.crates/*/Cargo.toml (9 files)
Added
rust-version.workspace = trueso each member crate inherits the workspace MSRV and reports it incargo metadata..github/workflows/ci.yml
Added a new
rust-msrvjob that extracts the MSRV fromCargo.tomlviased, installs that exact toolchain, and runscargo check --workspace --locked --all-targets. Uses a dedicatedSwatinem/rust-cachekey so it doesn't evict the main build cache.Reproduction Steps