-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat: migrate session metadata storage from frontend overlay to backend #8769
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
686f874
fix: retrieve the model for sessions from backend
baxen b0f43d5
refactor: rename ThreadMetadata.model_name to model_id
matt2e a9ed3ed
feat: store persona_id in backend session metadata
matt2e e5ea620
refactor: remove dead agentId field from session types
matt2e 4e83484
feat: expose remaining Thread fields in _meta and add rename endpoint
matt2e 417c280
feat: consume session metadata from backend, remove overlay writes
matt2e 099fe36
refactor: delete sessionMetadataOverlay module and update tests
matt2e 077d761
fix: use strict equality for userSetName instead of type cast
matt2e 197f241
fix: update test_list_sessions to expect new _meta fields
matt2e 5b2ad19
chore: regenerate ACP types
matt2e fcd0b2f
style: fix cargo fmt warning in acp_common_tests
matt2e de2b99d
fix: clear model_id when switching providers in update_provider
matt2e dfaaa67
style: remove unnecessary comment on model_id clearing
matt2e 4d4b961
fix: update thread persona_id on every message send
matt2e File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The rename RPC updates only the thread record, but other backend flows still read the internal session record (for example
on_export_sessiongoes throughsession_manager.export_session). After a rename, list sessions can show the new title while exported/imported session payloads still carry the old one, creating backend state drift introduced by this endpoint. Update the linked internal session name/user-set flag alongsidethread_manager.update_threadso both stores stay consistent.Useful? React with 👍 / 👎.