fix: correct WSL2 OS detection by removing PWD-based Windows override#8869
Open
JheisonMB wants to merge 1 commit intoaaif-goose:mainfrom
Open
fix: correct WSL2 OS detection by removing PWD-based Windows override#8869JheisonMB wants to merge 1 commit intoaaif-goose:mainfrom
JheisonMB wants to merge 1 commit intoaaif-goose:mainfrom
Conversation
Signed-off-by: Jheison Martinez Bolivar <jheison.mb@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes a bug in download_cli.sh where WSL2 was incorrectly detected as Windows when executed from a Windows-mounted directory (e.g., /mnt/c/...).
The script previously used $PWD to decide whether to install the Windows or Linux build of goose. In WSL2, uname -s correctly reports "Linux", but the script was overriding this based on the current working directory path. This caused:
Testing
Related Issues
Relates to #8672
Screenshots/Demos (for UX changes)
After:
