-
Notifications
You must be signed in to change notification settings - Fork 4.5k
render mcp apps inline in goose2 #8877
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
aharvard
wants to merge
12
commits into
main
Choose a base branch
from
codex/mcp-apps-step3-renderer
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
4a98035
Render MCP apps inline in Goose2
aharvard a5e49fb
Harden MCP app proxy bridge
aharvard c6cce85
fix(goose2): honor serve URL for app proxy host info
aharvard 92ba158
style(goose2): format serve override command
aharvard 62a7129
Remove Goose server proxy changes
aharvard e9b0b15
Harden MCP app proxy review feedback
aharvard 79efe17
Format Goose2 ACP command tests
aharvard cb452d8
Fail closed on MCP app guest storage errors
aharvard 0a91482
Address MCP app safety review feedback
aharvard 5e9043d
Validate MCP app CSP metadata
aharvard 3e4417b
Reject secure serve URLs for inline app sandbox
aharvard 35de9b5
Regenerate ACP schema types
aharvard File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Treating
GOOSE_SERVER__SECRET_KEYas valid whenever the variable exists meansGOOSE_SERVER__SECRET_KEY=""produces an empty shared secret, so/mcp-app-proxyand/mcp-app-guestauth can be satisfied with an emptysecretparameter/body. In environments where this var is templated but left blank, any loopback client (including arbitrary web pages reaching localhost) can use the MCP app proxy endpoints without guessing a key; trim/validate and either fail startup or fall back to a generated secret when the value is empty.Useful? React with 👍 / 👎.