Conversation
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 78e708f90b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| "icons/icon.icns", | ||
| "icons/icon.ico" | ||
| ], | ||
| "resources": ["../distro/**/*"], |
There was a problem hiding this comment.
The bundle config adds resources via "../distro/**/*", but the runtime resolver only checks resource_dir()/distro; in Tauri, .. segments are rewritten under _up_, so packaged builds will not find distro.json at the expected path and the distro bundle silently disappears unless GOOSE_DISTRO_DIR is manually set. This breaks the core production path (packaged app policy/flags) and should be fixed by making the bundled target path and lookup path consistent.
Useful? React with 👍 / 👎.
| prepend_path_env(&mut command, bin_dir); | ||
| } | ||
| if let Some(config_path) = &bundle.config_path { | ||
| command.env("GOOSE_ADDITIONAL_CONFIG_FILES", config_path); |
There was a problem hiding this comment.
Setting GOOSE_ADDITIONAL_CONFIG_FILES here overwrites any value inherited from the parent environment, so existing extra config layers are dropped whenever a distro config is present. In deployments that already rely on this env var (for policy or per-site defaults), those files stop loading after this change; append the distro path to the existing value instead of replacing it.
Useful? React with 👍 / 👎.
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 91518d0573
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 participant
No description provided.