feat: update provider row after saving credentials#8914
Merged
kalvinnchau merged 1 commit intomainfrom Apr 29, 2026
Merged
Conversation
switch first-time provider setup from the saved state directly to the connected controls after credentials are saved. this avoids requiring users to collapse and reopen the provider row before edit and disconnect are available.
kalvinnchau
changed the title
lifeizhou-ap
added a commit
that referenced
this pull request
Apr 30, 2026
* main: (24 commits) fix: copy and content improvements in goose2 (#8886) feat: make ollama host configurable in goose2 (#8912) polish sidebar navigation and project icons (#8896) fix: model picker stays usable during provider loading (#8900) feat: update provider row after saving credentials (#8914) feat: support google model inventory refresh (#8913) chore: Added goose 2 UI refactor review skill (#8903) blog: goose with peekaboo (#8884) blog: Built-in Local Inference blogpost. (#8808) perf: parallelize provider resolution and eagerly init SQLite pool (#8899) refactor: update goose2 credential management behind provider-scoped ACP/core API (#8887) fix: handle acp requests concurrently (#8781) build: set LLAMA_STATIC_CRT for Windows CUDA (#8901) perf: deduplicate _goose/providers/list RPC call at startup (#8873) chore: add a bit more instructions in the release pr (#8890) chore: disable spellcheck in model search (#8889) add skills to the chat composer (#8881) mergeable configs + cleanup (#8378) refactor: agent provider to use explicit type states (#8879) [goose2] MCP Apps: hydrate and replay app payloads in Goose2 (#8632) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Provider settings now show edit and disconnect controls immediately after users save credentials.
Problem: After entering an API key for a model provider, the expanded row stayed in a disabled saved state until the user collapsed and reopened it. That made the successful setup feel incomplete and hid the next available actions.
Solution: The provider row now follows the connected provider status immediately after setup save, so the expanded view switches directly to edit and disconnect. A regression test covers the Google Gemini API key setup flow.
File changes
ui/goose2/src/features/settings/ui/ModelProviderRow.tsx
Removes the local setup-layout preservation state that kept newly configured providers in the saved setup panel. Connected providers with fields now always render the connected field controls once their status updates.
ui/goose2/src/features/settings/ui/tests/ModelProviderRow.test.tsx
Adds a first-time Google Gemini setup test that saves an API key, updates the row to connected, and verifies edit and disconnect appear without reopening the provider row.
Screenshots/Demos
Before: saving a new API key left the row showing a disabled Saved button until the provider accordion was collapsed and reopened.
After: saving a new API key switches the open row directly to the connected state with Edit and Disconnect visible.
Verification:
./bin/pnpm --dir ui/goose2 test src/features/settings/ui/__tests__/ModelProviderRow.test.tsx