Added recipe discovery / execution to ACP server.#8925
Added recipe discovery / execution to ACP server.#8925natelastname wants to merge 1 commit intoaaif-goose:mainfrom
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 88955a934d
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| .split_whitespace() | ||
| .next() | ||
| .filter(|cmd| cmd.starts_with('/')) |
There was a problem hiding this comment.
Reuse command parser when emitting recipe-run feedback
This slash-command detection path uses split_whitespace() to extract the command token, but actual command execution in agents/execute_commands.rs splits only on a literal space (split_once(' ')). As a result, prompts like /recipe\targ or /recipe\narg will emit Running recipe: /recipe here even though the command dispatcher won’t resolve that recipe, so ACP clients get false execution feedback for commands that never run.
Useful? React with 👍 / 👎.
Summary
Adds ACP support for Goose slash command discovery and execution feedback.
This change introduces:
AvailableCommandlist from configuredslash_commands(global config)recipe.description→ command descriptionparameters[].description→ input hint (instead of hardcoded string)slash_commands(not all discovered recipes)Testing
I haven't included any actual unit tests, but I am happy to add some if this approach is accepted by the maintainers.
agent-shellin Emacs.)available_commands_update/speckit.constitution:Related Issues
Relates to ACP integration work (no specific issue yet)
Discussion: N/A
Screenshots/Demos (for UX changes)
This is not a UX change but here's a screenshot.