Lifei/UI improvements plan#8928
Conversation
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5249b5594b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1,435 @@ | |||
| **Goose2 Zustand State Management Improvement Plan** | |||
|
|
|||
| This plan translates the findings from [goose2-zustand-state-management-review.md](/Users/lifei/Development/goose/ui/goose2/ui_improvements/state_management/goose2-zustand-state-management-review.md) into a concrete implementation sequence. | |||
There was a problem hiding this comment.
Use repository-relative links for source references
The document hardcodes links to /Users/lifei/... paths (and many include :line suffixes), which only resolve on the author’s local machine and break for everyone else in GitHub/docs rendering. Because this plan depends on jumping to referenced files during implementation, these broken links materially reduce its usability and can lead to misapplied changes; convert them to repo-relative links (and line anchors like #L80 where needed).
Useful? React with 👍 / 👎.
| 4. Update `src/shared/api/acp.ts` so the default session working directory no longer falls back to a | ||
| hardcoded `~/.goose/artifacts` literal in frontend code. | ||
|
|
||
| 5. Keep existing `artifactsDir` during migration. |
There was a problem hiding this comment.
I'd like to have a broader discussion about the artifacts feature. The way it works today feels somewhat broken. I'd propose we drop it
Summary
Testing
Related Issues
Relates to #ISSUE_ID
Discussion: LINK (if any)
Screenshots/Demos (for UX changes)
Before:
After: