fix: keep renamed skills open in detail view#8935
Merged
kalvinnchau merged 1 commit intomainfrom Apr 30, 2026
Merged
Conversation
morgmart
approved these changes
Apr 30, 2026
Collaborator
morgmart
left a comment
morgmart
left a comment
There was a problem hiding this comment.
🤖 Reviewed locally and it looks good. Checks passed and I did not find any blocking issues.
github-merge-queue
Bot
removed this pull request from the merge queue due to no response for status checks
DOsinga
pushed a commit
that referenced
this pull request
Apr 30, 2026
Pulls in 7 new commits from main: - #8932 break up acp/server.rs into submodules - #8924 custom providers UI/ACP - #8935 keep renamed skills open in detail view - #8897 skill refactor (CreateSkillDialog -> SkillEditor) - #8886 copy/content polish - #8905 Gemini OAuth fix - #8546 command injection patterns Conflicts resolved: - crates/goose/src/acp/server.rs: took main's split structure; added project-related plumbing (properties, project_id, include_project_sources) into crates/goose/src/acp/server/sources.rs. - update_thread_metadata: pub(super) so server/sessions.rs (which hosts on_update_session_project) can call it. - ui/goose2/src/features/skills/api/skills.ts: dropped directoryPath/editable (not on main's SkillInfo); kept our projectName/projectDir lookup from backend properties. - ui/goose2/src/features/skills/ui/SkillEditor.tsx (renamed from CreateSkillDialog.tsx in #8897): kept main's structure; re-added our save-location picker (Global vs each project) and onSaved callback. - ui/goose2/src/shared/i18n/locales/en/skills.json: took main's casing for editTitle/newTitle; kept our new keys (global, globalHint, projectHint, saveLocation). Bumped useChatSessionController.ts file-size limit by 10 lines (840 -> 850); justification updated to mention ACP project sync.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Category: fix
User Impact: Users stay on the renamed skill's detail page after saving changes instead of being returned to the skills list.
Problem: Renaming a skill changed its ID, so the skills view could no longer match the previous active skill and fell back to the list page. This made a successful rename feel like it lost the user's place.
Solution: The editor now reports the saved skill back to the skills view, which refreshes the list and selects the saved skill ID when it is present.
File changes
ui/goose2/src/features/skills/ui/SkillEditor.tsx
Renamed the save callback to reflect both create and edit flows, and returns the saved skill from updates so the parent can keep the correct detail view selected.
ui/goose2/src/features/skills/ui/SkillsDialogs.tsx
Threaded the renamed save callback through the dialog wrapper so create and edit flows share the same post-save handling.
ui/goose2/src/features/skills/ui/SkillsView.tsx
Refreshes skills after a save and keeps the saved skill active when it appears in the refreshed list.
ui/goose2/src/features/skills/ui/tests/SkillEditor.test.tsx
Updated callback naming expectations to match the editor's broader save behavior.
ui/goose2/src/features/skills/ui/tests/SkillsView.test.tsx
Added coverage for renaming a skill and staying on the renamed skill's detail page.
Reproduction Steps