fix(goose2): avoid transform-rasterized dialog text#8937
Conversation
Center dialogs with an untransformed positioner instead of translating and scaling the content layer. This avoids macOS/Tauri WebView rasterizing dialog text on a composited transform layer, which is more visible on lower-DPI or scaled external displays.
kalvinnchau
force-pushed
the
kalvin/dialog-content-blur
branch
from
c6c7ebb to
b652a34
Compare
|
🤖 Pushed a follow-up fix for the dialog scroll-lock edge case we found during review. The update keeps the Radix Content element as the scroll container via inset/m-auto centering, which preserves the no-transform text rendering improvement while keeping react-remove-scroll tied to the allowed content ref. Also kept the newer overlay/content z-index layering from the rebased branch. |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 03d4bf8683
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 9229246e97
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
kalvinnchau
force-pushed
the
kalvin/dialog-content-blur
branch
from
9229246 to
46fd93d
Compare
2 participants
Category: fix
User Impact: Dialog text in Goose 2 renders more sharply on external displays.
Problem: On macOS/Tauri WebView, transformed text can be rasterized on a composited layer. That is usually hard to see on a Retina laptop display, but on lower-DPI or scaled external monitors, fractional pixel placement can make dialog text look blurry.
Solution: Center dialog surfaces with an untransformed positioner instead of translating and scaling the dialog content layer, while preserving fade transitions and allowing tall dialogs to scroll naturally.
File changes
ui/goose2/src/shared/ui/dialog.tsx
Moves dialog centering into a full-screen positioner so the content layer is no longer translated or scaled. Adds scroll-aware vertical layout for tall dialogs and keeps existing per-dialog width overrides working through Tailwind class merging.
ui/goose2/src/shared/ui/alert-dialog.tsx
Applies the same untransformed centering and scroll-aware layout to alert dialogs so confirmation surfaces follow the shared dialog rendering behavior.
Reproduction Steps
Screenshots/Demos
branch on left, main on right