Expand slider-bounded Σ/Π in the worker's graph analysis - #80
Merged
Conversation
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
equation | 116e2b2 | Commit Preview URL Branch Preview URL |
Aug 02 2026, 12:35 PM |
analyze() called resolveExpr without ResolveOpts, so any sum whose bound is a constant defined in another row — including the llms.txt Fourier example `N = 8; y = 2 sum[n=1..N] …` — failed create_graph and /g/ previews with "Σ bounds must be constant", while the app expands it fine. Build the same options web/main.ts does (constants at t = 0, minus animated constants and states, plus buildDefs' sumBoundConsts) and pass them to every resolveExpr call and to classifySeqRec. Animated and t-dependent bounds still fail with the app's own messages. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
aantthony
force-pushed
the
claude/worker-sum-bounds
branch
from
August 8, 2026 03:53
116e2b2 to
25d580e
Compare
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
equation | 25d580e | Commit Preview URL Branch Preview URL |
Aug 08 2026, 03:53 AM |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Rebased onto main (the random-variable worker support it was stacked on landed via #79). Fixes the parity gap: worker
analyze()calledresolveExprwith noResolveOpts, so any Σ/Π whose bound is a constant from another row failed with "Σ bounds must be constant" through MCPcreate_graphand/g/previews — including the Fourier example llms.txt itself ships (N = 8; y = 2 sum[n=1..N] (-1)^(n+1) sin(n x)/n). The app expands these fine.analyze()now builds the same options web/main.ts does — constants evaluated at t = 0, minus animated constants and states (expansion is static), plus thesumBoundConstssetbuildDefsalready returned but the worker discarded — and passes them to everyresolveExprcall (plot rows, distribution mean/sd,P(…)bodies) and toclassifySeqRec.Behavior
N = 8; y = 2 sum[n=1..N] …→ validates, classifiesimplicit2d, draws in the preview (Σ expands before compile, so the vm needs nothing new).X ~ Normal(sum[n=1..N] 1/n, 1); the P readout verifies against the normal CDF) and in sequence rows.Tests
Two new end-to-end
create_graphcases: the Fourier example validates with nothing omitted from the preview, and the animated-constant bound still errors. 629 passing after the rebase (ropts is also wired into the post-#79 call sites: buildRVSystem and E(…) rows); typecheck clean.🤖 Generated with Claude Code
Migrated from equation-src#58 as part of the open-source move.