Add new option 'highlight_group' #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Add some tests and fix the indentation and I'll merge it 🙂 |
|
Oops, I fixed the indentation, (autoformatter) |
|
Alright I went ahead and merged into a branch and made some of the changes I was talking about (plus some extra detail on the readme). Go ahead and check out that commit here. You can check the |
|
You're awesome! Thank you so much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi! Thanks for the amazing plugin; navigating the code has become even more convenient. However, I have an issue. The highlight group you chose for highlighting moving objects conflicts with my configuration. Another plugin overwrites it, and there's nothing I can do about it. Could you please accept my PR that adds a new option to your plugin, allowing the highlight group to be customized? I would be very happy :)