Skip to content

Php8.2 fixes #14

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
DavidGoodwin wants to merge 11 commits into
base: main
Choose a base branch
from
Open

Php8.2 fixes #14

DavidGoodwin wants to merge 11 commits into from

Conversation

@DavidGoodwin
Copy link

@DavidGoodwin DavidGoodwin commented Mar 12, 2024

  • relax composer.json to allow phpunit to get installed in PHP 8.2
  • update tests to extend \PHPUnit\Framework\TestCase instead of PHPUnit_Framework_TestCase
  • token fixes to some unit tests
  • remove composer.lock file

@DavidGoodwin
relax constaint around phpunit in composer.json so we can run unit te…
a4c2d52 
…sts under php8.2
@DavidGoodwin
update unit tests to extend \PHPUnit\Framework\TestCase instead of PH…
a798eec 
…PUnit_Framework_TestCase
@DavidGoodwin
use $this->expectException instead of @ExpectedException
451e786
@DavidGoodwin
use output buffering to capture the output from unit tests rather tha…
143decc 
…n allowing it to go to stdout, also fix a couple of urls to avoid redirects confusing the test
@DavidGoodwin
fix phpdoc - this returns self not string
4991700
@DavidGoodwin
php8.2 does not like this nesting, try and guess where the brackets s…
f99f007 
…hould be
@DavidGoodwin
fix some unit tests
e3fc6a5
@DavidGoodwin
fix test (feed location moved)
b279797
@DavidGoodwin
drop composer.lock file - seems unnecessary especially if this should…
c4f181d 
… work under multiple PHP versions
@DavidGoodwin
missing fixture file
b0097b6
@lostfocus lostfocus mentioned this pull request Mar 16, 2024
Open
@DavidGoodwin DavidGoodwin mentioned this pull request May 28, 2024
Merged
DavidGoodwin added a commit to orlo/picofeed that referenced this pull request May 28, 2024
@DavidGoodwin
Merge pull request #1 from DavidGoodwin/php8.2-fixes
a15f2f2 
Php8.2 fixes
see also aaronpk#14
@DavidGoodwin
add ReturnTypeWillChange annotations to suppress : Return type of Pic…
0e318a2 
…oFeed\Client\HttpHeaders::offsetExists($offset) should either be compatible with ArrayAccess::offsetExists(mixed $offset): bool, or the #[\ReturnTypeWillChange] attribute should be used to temporarily ....
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@DavidGoodwin