Fix startrails moonmode settings, fixes #2832#2880
Open
tswfi wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
doh, I wasn't on latest main. sec. I will double check :) |
The toggle is inverted and the fields should actually be disabled when the toggle is off. Added a "inverted" parameter for the fields and made the texts a bit clearer
tswfi
force-pushed
the
fix_moon_mode_startrails_settings
branch
from
86a8bf2 to
1e66a06
Compare
Contributor
Author
|
so this commit 5c2a741#diff-a03dc2ef5764296135515113bda2d1cd2b345b3c240b3984722164c33e51a116 changed the text but didn't change the logic at all? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The toggle is inverted and the fields should actually be disabled when the toggle is off.
Added a "inverted" parameter for the fields and made the texts a bit clearer.