Quote string scalars that resolve to null (#493) - #1126
Open
gaoflow wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
A
stringequal to a null token (~,null,Null,NULL) is emitted as a plain scalar, so it deserializes back tonulleven when the target isstring— the serializer emits output its own deserializer reads as a different type (#493).TypeAssigningEventEmitternow quotes a string scalar whose plain form matches the exact setNullNodeDeserializertreats as null, so it round-trips. Only that set is quoted —nUll/nullishstay plain — and actual nulls are unaffected (still emit barenull). It is the same setWithQuotingNecessaryStringsalready quotes, applied unconditionally for the null tokens because, unlike bool/number look-alikes, they lose data even for astringtarget.Tested: the four tokens round-trip as scalars and dictionary values, look-alikes stay unquoted, and real null still emits bare.