[Fix] Add zero address validation for onBehalfOf in supply() #119
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds a validation check to ensure the
onBehalfOfaddress in thesupply()function is not the zero address.Reasoning
Passing the zero address as
onBehalfOfcould cause undefined behavior or unintended token assignment.Adding this check prevents potential misuse or loss of funds.
Code Location
File:
src/contracts/protocol/pool/Pool.solFunction:
supply(address asset, uint256 amount, address onBehalfOf, uint16 referralCode)Fix